make sure we always send apns-expiration as integer number #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mman, it looks like the tests need an update too! |
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 256 256
=====================================
Hits 256 256
Continue to review full report at Codecov.
|
Contributor
Author
|
@flovilmart tests updated and passing. |
mman
changed the title
flovilmart
approved these changes
Feb 13, 2018
Contributor
|
Thanks for the PR, i’ll Plan out a release soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request quickly addresses the issue where
apns-expirationheader that gets sent to the Apple Push Notification Service gets wrongly computed into a floating point number thus generating push error 400 BadExpirationDate reported here parse-community/parse-server#4558.I have tested in production that this fix gets rid of the error and pushes are going through.
I have not tested or reviewed the logic of computing correct push expiration date from push date.